-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flashrom: bump flashrom to upstream 1.3 and fix flash.sh progress_bar #1423
Conversation
Testing request under #1398. |
Now that master has sizes.txt and console output of sizes of built binaries etc, rebasing on master and addressing @JonathonHall-Purism comment #1398 (comment) |
12b0199
to
fd7290c
Compare
Update flashrom - in particular, this includes support for new chipsets like Jasper Lake. CONFIG_INTERAL_X86 was created so CONFIG_INTERNAL could apply to other platforms, enable it for x86. The default build target now requires sphinx, just build flashrom itself. Update flashrom_progress - filter out noise in newer flashrom that chokes the progress bar implementation, make size detection more robust, improve progress bar implementation slightly. Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm> Co-signed by: Thierry Laurion <insurgo@riseup.net.
…e MTD only for ppc64, have AST1100 enablement configurable for kgpe-d16 (patch not in)
fd7290c
to
979c9dd
Compare
Ok time for comparisons!!!! Master last commit includes sizes.txt report. We will use t520-hotp-maximized sizes output step to compare cost of PR addition here. The raw output is available here. which we will use with diff to see what changed.
|
Some analysis
This is a direct free coreboot cbfs free space of 3981824-3977216=4608 (compressed) bytes |
Based on commit JonathonHall-Purism@2bb58f7
TODO: probably split flashrom into flashrom-stable/flashrom-upstream/flashrom-dasharo and have boards use the one needed. I suspect flashrom-stable will be even smaller.
Good news is that #1422 #1381 and this PR merged under #1398 can be compiled for legacy boards, dodging #1421 issue for the moment.