Revert "Merge pull request #1703 from JonathonHall-Purism/purism_coreboot_24.02.01" #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Working on bisecting the actual problem, but I'll test this branch as soon as CI ROMs are up. If it does boot and I haven't found the actual fix by then, we'll merge it. |
JonathonHall-Purism
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
I built this locally (ended up beating CI) and it does fix the issue, so let's merge it while I figure out what's going on.
What's bizarre though is that the same commit was fine in the PureBoot 30 release, I cherry picked it over there since IIRC it wasn't merged yet upstream, and all tests passed. I'll figure it out, let's revert this for now.
|
Will revert latest docker image to 0.1.9 now. |
4 tasks
JonathonHall-Purism
added a commit
to JonathonHall-Purism/heads
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7025031, reversing changes made to 156d2c8 from #1703 diagnosed and fixed.
This is to prevent other users internally upgrade and brick their computers.
This is interim fix to #1712