Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPG2 Fixes #505

Merged
merged 4 commits into from
Jan 26, 2019
Merged

GPG2 Fixes #505

merged 4 commits into from
Jan 26, 2019

Conversation

itay-grudev
Copy link
Contributor

@itay-grudev itay-grudev commented Jan 3, 2019 •
edited
Loading

  • Removed --no-tty as it disables the card admin PIN pinentry in initrd/bin/kexec-sign-config
  • Added the CONFIG_GPG2 flag in the Librem boards
  • Disabled libsecret support in the pinentry module

@itay-grudev itay-grudev mentioned this pull request Jan 3, 2019
Closed
@jandryuk
Copy link
Contributor

jandryuk commented Jan 3, 2019

@tlaurion specifically had to add --no-tty here: cc89d68

@itay-grudev
Copy link
Contributor Author

itay-grudev commented Jan 3, 2019 •
edited
Loading

I think the original issue no longer exists after setting the GPG_TTY=$(tty) in #491. And now it fails because it can't prompt for PIN.

@itay-grudev itay-grudev changed the title Removed --no-tty as it disables the card admin PIN pinentry GPG2 Fixes Jan 4, 2019
tlaurion
tlaurion approved these changes Jan 6, 2019
View reviewed changes
Copy link
Collaborator

@tlaurion tlaurion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

initrd/bin/kexec-sign-config Outdated Show resolved Hide resolved
@itay-grudev
Copy link
Contributor Author

Ping!

@tlaurion tlaurion merged commit 1699771 into linuxboot:gpg2 Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlaurion tlaurion tlaurion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itay-grudev @jandryuk @tlaurion