CircleCI: readd librem_mini #832
Conversation
…ails, all logfile modified in the last minute are outputted on the screen prior to really failing and exiting
tlaurion
changed the title
|
@tlaurion it boots but isn't functional, seems to be missing a lot of handling for the non-TPM case |
|
@MrChromebox |
|
@MrChromebox : you need two board configs, one with TPM and one without, just like in 004e36f ? |
…fig (required per Heads build system) to construct a ROM without TPM requirement.
tlaurion
force-pushed
the
librem_mini-log_output_modified_last_minute_in_all_tree
branch
from
004e36f
to
3db7214
Compare
|
@MrChromebox So following 3db7214 built https://app.circleci.com/pipelines/github/tlaurion/heads/387/workflows/498762bd-a640-4bb0-9cf0-ba7d66d71abb/jobs/416 librem_mini-NoTPM: librem_mini (with TPM): |
|
@tlaurion the Librem Mini doesn't have a TPM, so the w/TPM build isn't useful. The no-TPM build works better than the initial one (I was able to perform a factory reset), but still fails due to some functions expecting a TPM and not handling the lack of one properly (like generating a new secret) |
|
@MrChromebox : You want me to delete the standard board and replace with the NoTPM board? This PR shows that building coreboot 4.12 and coreboot 4.8.1 from CI works. AFAIK Librem Key/Nitrokey Pro/ Nitrokey Storage HOTP support for TPM less board is stalled with proposed improvements here: |
|
@tlaurion please do. I must have missed the explicit export when upstreaming since #493 (or some version thereof) is in Purism's tree and so explicitly setting TPM=n isn't necessary. w/r/t #493, what needs to happen there to move it forward? Or, are there smaller chunks within it that could be easily accepted now to improve the non-TPM case? |
@MrChromebox: I am not sure about this implementation, TBH. We are talking about TPM being auto-detected and used if found, and codepath changing if not, right? I think those discussions should happen in seperate PRs. So for the current one. You want me to delete librem_mini board dir and associated coreboot config and keep the librem_mini-NoTPM board and coreboot config? Please resume discussion inside of #493 and do PR to propose dynamic TPM detection upstream. We want the less changes between upstream Heads and sidetracked implementations, else we do not know what we are talking about. This is why CIs and testing built roms (and making sure repro is met) are for. :) |
…librem_mini-NoTPM and coreboot config only. Removed librem_mini board build under CircleCI, keeping only librem_mini-NoTPM
correct
copy that |
while making sure that if a board build f…ails, all logfiles modified in the last minute are outputted on the screen prior to really failing and exiting.