xx30-*-maximized linux 4.19.162 mmc support: add external storage support #924
Conversation
|
Added LUKS mount support @MrChromebox . If you want me to split this up in another PR, no problem. Tested. But of course, if user fails into entering his LUKS passphrase more then one loop of cryptsetup, the partition being mounted is not replaced and the current code doesn't deal well with unsupported partition so it goes into recovery shell. Another thing is that if user provides both USB drive and sdcard, only one out of the two will present partitions for user to pick from. Not an issue for me but if you have a path to suggest, that would be welcome. I remember we had debate on adding external storage support altogether but you had restrictions on merging stuff first. I think now would be a good moment to migrate usb support to more general support for external storage support; hence moving mount-usb and usb-init to their more general counterpart (renaming would be just fine). |
|
@tlaurion not an issue right now, but eventually we might end up with a device that uses internal eMMC and need to distinguish between internal/fixed and external/removable media. I'll do a more thorough review tomorrow |
|
@MrChromebox ping! |
|
@tlaurion would it not make sense to have a 3rd commit in this PR that renames mount-usb to mount-external (and adjusts usages accordingly)? |
… mount-external-storage everywhere) mount-usb: add capability do deal with encrypted LUKS container prior of mounting device. /etc/functions: now has a enable_mmc counterpart of enable_usb which checks for CONFIG_LINUX_MMC declared in board config
tlaurion
force-pushed
the
xx30-maximized-linux-4.19.162_MMC_support_mount-external-storage
branch
from
5343fd3
to
5e16ae4
Compare
…change all references in codebase.
tlaurion
force-pushed
the
xx30-maximized-linux-4.19.162_MMC_support_mount-external-storage
branch
from
5e16ae4
to
c87de93
Compare
|
@MrChromebox last commit moves mount-usb to mount-external-storage, and changes all references in codebase to point to it. |
@MrChromebox : waiting for your approval into renaming mount-usb to mount-external-storage and apply changes in all codebase, which is point 3 of generating GPG keys under heads and keytocard that I would do in this PR.