fix: 卸载第三方应用后任务栏依然显示应用 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/integrate |
|
应用商店里面的应用是怎么处理的？ |
|
AutoIntegrationPr Bot |
|
问题应该不在这，应该是 https://github.com/linuxdeepin/dde-application-manager/blob/master/src/modules/dock/dock.cpp#L1411-L1419 出了问题。 这样采用launcher拆卸时发送信号的操作，会导致从其他入口，比如终端拆卸时。没有触发此处代码，导致依旧无法移除对应的Entry。 |
|
commit 标题中不要描述自己修了什么bug 而是应该描述自己做了什么更改。 比如说这次应该是 “fix(launcher): 修正onCheckDesktopFile的行为” 之类的吧？ |
应该使用m_desktopAndItemMap而不是itemsMap去获取对应的Item Log: 修复卸载第三方应用后任务栏依然显示应用的问题 Influence: 任务栏应用正常显示
black-desk
approved these changes
Jun 25, 2023
|
/integrate |
|
/integrate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
应该使用m_desktopAndItemMap而不是itemsMap去获取对应的Item
Log: 修复卸载第三方应用后任务栏依然显示应用的问题
Influence: 任务栏应用正常显示
Resolve: linuxdeepin/developer-center#4630