-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 增加dock栏鼠标悬停item背景加深 #874
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA. |
/recheck |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个有涉及对现有行为的调整,请详细描述下变动前和变动后的行为差异,以便于产品/设计人员评估是否可以合入相关变动,或提供配置项并保持默认行为为原有行为。
frame/item/dockitem.cpp
Outdated
@@ -23,6 +23,7 @@ QPointer<DockPopupWindow> DockItem::PopupWindow(nullptr); | |||
DockItem::DockItem(QWidget *parent) | |||
: QWidget(parent) | |||
, m_hover(false) | |||
, m_down(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, m_down(false) | |
, m_pressed(false) |
变动前:在鼠标悬停在dock栏的item上不会绘制一个矩形。 |
recheck |
?你怎么关了 |
不是我关的你信不?我还纳闷 怎么没了 |
dock栏鼠标悬停item背景加深 Log: 增加dock栏鼠标悬停item背景加深
if(m_hover && !m_pressed) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(m_hover && !m_pressed) | |
{ | |
if (m_hover && !m_pressed) { |
}else if(m_hover && m_pressed) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}else if(m_hover && m_pressed) | |
{ | |
} else if (m_hover && m_pressed) { |
if(m_hover && !m_pressed) | ||
{ | ||
QPainter painter(this); | ||
painter.setBrush(QBrush(QColor(248, 248, 255))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个颜色无论亮色与暗色主题均保持同一个颜色吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,这个颜色是固定的,无论主题是否变化
这个问题我,需要先和UI和UED设计沟通一下,他不仅仅是个需求更多涉及交互问题。 |
TAG Bot New tag: 6.0.26 |
TAG Bot New tag: 6.0.27 |
TAG Bot New tag: 6.0.28 |
TAG Bot New tag: 6.0.29 |
TAG Bot New tag: 6.0.30 |
TAG Bot New tag: 6.0.31 |
TAG Bot New tag: 6.0.32 |
TAG Bot New tag: 6.0.33 |
TAG Bot New tag: 6.0.34 |
TAG Bot New tag: 6.0.35 |
TAG Bot New tag: 6.0.36 |
TAG Bot New tag: 6.0.37 |
dock栏鼠标悬停item背景加深
Log: 增加dock栏鼠标悬停item背景加深
edit by maintainer:
mmexport1686380141410_Trim.mp4
效果视频,视频由原作者提供