Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try to update icon cache again #294

Merged
merged 1 commit into from
May 31, 2024

Conversation

kegechen
Copy link
Contributor

/opt/apps installed will update hicolor
watch /usr/share/icons/hicolor/icon-theme.cache modified to update icon cache..

Issue: linuxdeepin/developer-center#8577

@kegechen kegechen requested review from BLumia and 18202781743 May 28, 2024 10:25
@kegechen kegechen force-pushed the try_update_iconcache branch from 572f77f to 903ed62 Compare May 29, 2024 02:36
src/models/appsmodel.cpp Outdated Show resolved Hide resolved
@BLumia BLumia requested a review from wineee May 29, 2024 03:11
@kegechen kegechen force-pushed the try_update_iconcache branch from 903ed62 to f57efdf Compare May 29, 2024 05:30
@deepin-bot
Copy link

deepin-bot bot commented May 30, 2024

TAG Bot

New tag: 0.7.0
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #297

@kegechen kegechen force-pushed the try_update_iconcache branch from f57efdf to 1d6e02c Compare May 30, 2024 09:02
/opt/apps installed will update hicolor
watch /usr/share/icons/hicolor/icon-theme.cache modified
to update icon cache..

Issue: linuxdeepin/developer-center#8577
@kegechen kegechen force-pushed the try_update_iconcache branch from 1d6e02c to a4c286d Compare May 30, 2024 09:03
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • AppsModel::AppsModel构造函数中,使用qOverload来连接AppMgrchanged信号到QTimerstart方法可能不是最佳实践。建议使用更明确的信号和槽连接方式。
  • m_fwIconCachem_tmUpdateCache在构造函数中被初始化为nullptr,但在后续代码中没有看到它们被正确设置为非nullptr的值。
  • m_tmUpdateCache的定时器间隔设置为1000毫秒,但m_fwIconCache没有设置监听文件的路径,这可能导致DFileWatcherManager无法正确工作。
  • connect信号和槽连接时使用了匿名函数,这可能会导致在信号连接管理上的问题,建议使用命名槽函数或使用QMetaObject来连接信号和槽。
  • IconUtils::tryUpdateIconCache函数调用时没有检查返回值,如果IconUtils的更新缓存操作失败,可能会导致程序在运行时出现未处理的异常。
  • m_tmUpdateCache的定时器连接到updateModelData槽函数,但没有考虑到updateModelData可能不是槽函数,这可能会导致定时器触发时槽函数无法正确执行。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit e89c24f into linuxdeepin:master May 31, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants