Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: window radius isn't changed #102

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: window radius isn't changed #102

merged 1 commit into from
Sep 25, 2024
+6 −1

Conversation

FeiWang1119
Copy link
Contributor

window radius isn't changed by dcc

Log:
Bug: https://pms.uniontech.com/bug-view-273039.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在AnimationViewContainer类中新增的#include <DPlatformTheme>是否必要，如果该头文件没有在其他地方使用，则应该移除。
  • 新增的槽函数connect可能需要添加错误处理或检查m_windowHandle是否为nullptr。
  • NotifyCenterWidget中的connect槽函数被移除，需要确认这是否是有意为之，因为这可能会影响窗口圆角的更新。

是否建议立即修改:

  • 是，特别是对于新增的槽函数，需要确保代码的健壮性和正确性。
  • 是，如果移除NotifyCenterWidget中的connect槽函数是无意的，应该立即恢复。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FeiWang1119 FeiWang1119 merged commit e61cdd1 into linuxdeepin:master Sep 25, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@18202781743 18202781743 18202781743 approved these changes

@xionglinlin xionglinlin Awaiting requested review from xionglinlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FeiWang1119 @deepin-ci-robot @18202781743