Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The notification center panel is too close to the edge #96

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jun 21, 2024

Change to 10px from the edge

Issue: linuxdeepin/developer-center#9373

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • getGeometry函数中,对x坐标的修改可能会导致布局问题,需要确认是否有其他代码依赖于getGeometry的结果。
  • 修改后的代码没有处理x - UI::Widget::WindowMargin小于0的情况,可能会导致坐标计算错误。

是否建议立即修改:

@mhduiy mhduiy merged commit 3026678 into linuxdeepin:master Jun 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants