Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show hidden animation lag #99

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Aug 27, 2024

  • Show hidden default animations using the window manager
  • Optimize animations that enter editing mode

Issue: linuxdeepin/developer-center#9728

- Show hidden default animations using the window manager
- Optimize animations that enter editing mode

Issue: linuxdeepin/developer-center#9728
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • AnimationViewContainer类中,currentX属性的类型从int更改为qreal,需要确认是否有相应的类型转换和溢出检查。
  • setCurrentX方法中的参数xint更改为qreal,应确保调用此方法的代码也进行相应的修改。
  • m_targetRect的类型从int更改为QRectF,应确保所有使用此变量的代码都已经做了相应的修改。
  • 移除了AnimationViewContainer类中的paintEvent方法,如果这个方法是必要的,应该考虑其他方式来处理绘制事件。
  • regionMonitorHide方法中,移除了对m_currentXAni状态的检查,如果动画正在运行,可能会导致问题。

是否建议立即修改:

  • 确保类型更改不会影响现有的功能,并且进行了必要的错误处理和检查。
  • 检查是否有必要进行这样的更改,因为qreal类型通常用于表示浮点数,而int类型可能更适用于整数。
  • 验证paintEvent方法的移除是否会影响其他部分的绘制逻辑,并考虑是否需要其他方式来处理绘制事件。
  • 重新审视regionMonitorHide方法的修改,确保动画的停止逻辑不会引入新的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 7e86b39 into linuxdeepin:master Aug 27, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants