Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[cmd] remove bash use #188

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

starhcq
Copy link
Contributor

@starhcq starhcq commented Sep 10, 2024

remove bash use

Log: remove bash use
Task: https://pms.uniontech.com/task-view-362321.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 使用QStandardPaths::findExecutable替代手动执行bash命令,简化了OCR可执行文件检查的逻辑。
  • 移除了不必要的QProcess和QString操作,提高了代码的简洁性和可读性。

是否建议立即修改:

  • 否,提交的代码已经是一个改进的版本,没有立即需要修改的问题。但是,如果有更多的上下文,比如代码的其它部分,可能会有其他的问题需要关注。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@starhcq starhcq merged commit 508e7ea into linuxdeepin:release/eagle Sep 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants