Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add -C option to enable Compress #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shenmo7192
Copy link

  • feat: enable compress when ssh connect. This is very useful when ssh x forwarding

* feat: enable compress when ssh connect. This is very useful when ssh x forwarding
@ArchieMeng
Copy link
Contributor

ArchieMeng commented Mar 12, 2023

Thank you for your contribution.
However, this change should be reconsidered according to the following information.

     -C      Requests compression of all data (including stdin, stdout, stderr, and data for forwarded X11, TCP and UNIX-domain connections).  The compression al‐
             gorithm is the same used by gzip(1).  Compression is desirable on modem lines and other slow connections, but will only slow down things on fast net‐
             works.  The default value can be set on a host-by-host basis in the configuration files; see the Compression option in ssh_config(5).

Compression is desirable on modem lines and other slow connections, but will only slow down things on fast net

To my understanding, it would be much better if it can be implemented as an optional setting.

@shenmo7192
Copy link
Author

Thank you for your contribution. However, this change should be reconsidered according to the following information.

     -C      Requests compression of all data (including stdin, stdout, stderr, and data for forwarded X11, TCP and UNIX-domain connections).  The compression al‐
             gorithm is the same used by gzip(1).  Compression is desirable on modem lines and other slow connections, but will only slow down things on fast net‐
             works.  The default value can be set on a host-by-host basis in the configuration files; see the Compression option in ssh_config(5).

Compression is desirable on modem lines and other slow connections, but will only slow down things on fast net

To my understanding, it would be much better if it can be implemented as an optional setting.

I think the compression perform loss is totally acceptable in modern computers, so I think it can be a default.

Also the compression makes it possible to use X11 forwarding on not so good network.

@felixonmars
Copy link
Member

-1. It's a burden for lower end boxes, VPS, development boards etc. Hardcoding to force-enable it is not acceptable here.

Please consider utilizing existing ssh_config mechanism, i.e. setting "Compression yes" yourself in either ~/.ssh/config or /etc/ssh/ssh_config either for all hosts, or individually for specific hosts.

Copy link
Contributor

@ArchieMeng ArchieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding is not acceptable here.

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 25, 2023

TAG Bot

New tag: 5.9.47
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #322

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 10, 2024

TAG Bot

New tag: 5.9.48
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #327

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 15, 2024

TAG Bot

New tag: 5.9.49
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #329

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 25, 2024

TAG Bot

New tag: 6.0.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #332

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 1, 2024

TAG Bot

New tag: 6.0.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #334

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 12, 2024

TAG Bot

New tag: 6.0.12
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #339

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 2, 2024

TAG Bot

New tag: 6.0.13
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #345

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 5, 2024

TAG Bot

New tag: 6.0.14
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants