Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug# 点击自定义主题后未确认,菜单勾选状态错误 #343

Merged
merged 1 commit into from
May 21, 2024

Conversation

DaiZW007
Copy link
Contributor

@DaiZW007 DaiZW007 commented May 9, 2024

由于自定弹窗结果返回是异步的,所以修改为:
每次菜单点开重新进行勾选

Log: 点击自定义主题后未确认,菜单勾选状态错误

@deepin-ci-robot
Copy link

Hi @DaiZW007. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DaiZW007
Copy link
Contributor Author

DaiZW007 commented May 9, 2024

自己写出来的bug,要自己解决掉☺

@DaiZW007
Copy link
Contributor Author

@ArchieMeng

@ArchieMeng
Copy link
Contributor

收到,有空会看的。

由于自定弹窗结果返回是异步的,所以修改为:
每次菜单点开重新进行勾选

Log: 点击自定义主题后未确认,菜单勾选状态错误
Copy link
Contributor

@ArchieMeng ArchieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, DaiZW007

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng ArchieMeng merged commit 562b849 into linuxdeepin:master May 21, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants