Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed issue with lsp invalid #854

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: Fixed issue with lsp invalid #854

merged 1 commit into from
Aug 2, 2024

Conversation

Kakueeen
Copy link
Contributor

@Kakueeen Kakueeen commented Aug 1, 2024

as title

Log: fix issue

as title

Log: fix issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码重复:在新增的代码更改中,generator->doProjectOpen(kitName, language, workspace); 被重复调用,可能需要检查是否有必要。
  • 缺少注释:代码更改中没有注释来解释为什么需要重复调用相同的函数,这可能会让其他开发者感到困惑。

是否建议立即修改:

@deepin-mozart deepin-mozart merged commit 17bfbc5 into master Aug 2, 2024
10 of 11 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepin-mozart, Kakueeen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants