Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: from linuxdeepin/dtkwidget #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sync: from linuxdeepin/dtkwidget #86

wants to merge 1 commit into from
+14 −2

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#609

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
sync: from linuxdeepin/dtkwidget
e5e0d9e 
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#609
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • 在checkStateSet私有函数中，直接修改了checked状态，可能会导致状态不一致的问题。
  • DDciIcon::fromTheme("switch_on")和DDciIcon::fromTheme("switch_off")的调用可能依赖于checked状态，但当前的调用顺序没有反映这种依赖关系。
  • d->player.setIcon(icon);这行代码可能会导致icon在使用前未进行正确初始化。

是否建议立即修改:

  • 是

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepin-ci-robot