Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

弹出设备图标显示不正确<周三> #495

Closed
liuwen123 opened this issue Nov 27, 2018 · 6 comments
Closed

弹出设备图标显示不正确<周三> #495

liuwen123 opened this issue Nov 27, 2018 · 6 comments
Assignees
@liuwen123
Milestone
15.8.2

Comments

@liuwen123
Copy link

【测试步骤】
使用NTFS格式的U盘插入PC并挂载成功，然后向U盘拷贝文件，文件拷贝完成后点击弹出按钮

【预期结果】
弹出提示对话框，内容显示正确

【测试结果】
弹出提示对话框，图标显示不正确

【问题级别】

【出现概率】
11
@liuwen123 liuwen123 added this to the 15.8.1 milestone Nov 27, 2018
@zccrs
Copy link
Member

zccrs commented Nov 27, 2018

@BLumia 这个图标是从主题拿的吗？看看大小设置的对不对

@zccrs zccrs modified the milestones: 15.8.1, 15.8.2 Nov 28, 2018
@kanbanmgr
Copy link

kanbanmgr bot commented Dec 10, 2018

设置截止日期到 2018-12-12

@zccrs zccrs changed the title 弹出设备图标显示不正确 弹出设备图标显示不正确<周三> Dec 10, 2018
@BLumia
Copy link
Member

BLumia commented Dec 12, 2018

这个问题好像之前说过，是 DTK 的问题， DDialog 只使用给出的第一个可用大小作为 Icon 。

截图的地方是这里（也可以做最小化复现代码）：

void DialogManager::showErrorDialog(const QString &title, const QString &message)
{
    DDialog d(title, message);

    d.setIcon(QIcon::fromTheme("dialog-error"));
    d.addButton(tr("Confirm"), true, DDialog::ButtonRecommend);
    d.setMaximumWidth(640);
    d.exec();
}

@kanbanmgr kanbanmgr bot added the delayed label Dec 12, 2018
deepin-gerrit pushed a commit to linuxdeepin/dtkwidget that referenced this issue Dec 13, 2018
@BLumia
feat: allowed set a expected icon size for DDialog::setIcon
a4d2aa0 
linuxdeepin/internal-discussion#495

Change-Id: Ie781218474e86686f54b2149d86cb1eb669cf20d
@BLumia
Copy link
Member

BLumia commented Dec 13, 2018

https://cr.deepin.io/#/c/dde/dde-file-manager/+/40515/

@BLumia BLumia assigned liuwen123 and unassigned BLumia Dec 13, 2018
@liuwen123
Copy link
Author

+1

deepin-gerrit pushed a commit to linuxdeepin/dde-file-manager that referenced this issue Dec 13, 2018
@BLumia
fix: Dialog size not correct when using icon from theme
520e4de 
linuxdeepin/internal-discussion#495

Change-Id: Iab1dc667c5a30a998959295a38e10c5306f83f5a
@liuwen123 liuwen123 removed the delayed label Dec 13, 2018
@liuwen123
Copy link
Author

已修复

deepin-gerrit pushed a commit to martyr-deepin/deepin-code-release that referenced this issue Dec 29, 2018
topic: 15.8.2-2
e11bd64 
qt5integration:
* 绘制按钮图标时，对于支持改变颜色的图标，将其颜色跟随按钮的文字颜色

deepin-editor:
* 修复另存为时内容消失
* 提示原文件已丢失
* 支持触屏操作

deepin-wallpapers:
*  替换默认壁纸

dde-file-manager:
* 支持选中多个文件时（如果其类型近似则）在上下文菜单中显示打开方式选项 （linuxdeepin/internal-discussion#539）
* 修复在列表模式时，扩展名始终会被显示为小写的问题
* 修复弹出的提示框中图标大小不正确（过小）的问题 （linuxdeepin/internal-discussion#495）
* 在“系统盘”侧栏项目上下文菜单中显示文字由 “属性” 调整为 “磁盘信息” （linuxdeepin/internal-discussion#601）

dde-dock:
* 修复托盘图标触发拖拽过于灵敏 https://tower.im/projects/e4ae1ad0b5d5497fb4b7c14fe2d2efbf/todos/d6bbed3e1c2bd8928a028c74b193d30a/
* 修复刚开机时一些开机自启动应用的托盘图标无法右键显示菜单 linuxdeepin/internal-discussion#660
* 修复网络提示没有及时更新 https://tower.im/projects/e4ae1ad0b5d5497fb4b7c14fe2d2efbf/todos/a7c3481830dab3290d1a1c9580883c92/
* 修复托盘图标在触摸屏下长按显示菜单的问题 linuxdeepin/internal-discussion#619

lastore-daemon:
* 智能镜像源

go-dbus-factory:
* add org.freedesktop.NetworkManager ObjectManager

dde-daemon:
* 处理无线网络加密类型更改
* 支持屏保
* 修正自动探测grub分辨率相关bug
* 修正任务栏驻留图标bug

dde-api:
* 当grub主题分辨率为1280x1024时，只显示4行选项的问题

deepin-desktop-schemas:
* 专业版默认不开启自动调节亮度
* 修改触摸屏长按时长默认值

dde-control-center:
* 添加智能镜像源

deepin-mutter:
*   解决华为项目上触摸屏操作卡死问题

commit by electricface
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@liuwen123 liuwen123

Labels
None yet
Projects
None yet
Milestone
15.8.2
Development

No branches or pull requests
3 participants
@BLumia @liuwen123 @zccrs