Skip to content

fix: tooltip not clickable on overview tab#1645

Merged
emlimlf merged 3 commits intomainfrom
fix/health-score-tooltip
Feb 4, 2026
Merged

fix: tooltip not clickable on overview tab#1645
emlimlf merged 3 commits intomainfrom
fix/health-score-tooltip

Conversation

@emlimlf
Copy link
Collaborator

@emlimlf emlimlf commented Feb 3, 2026

In this PR

  • Re-enabled the tooltip on the overview tabs
  • Added pass-through flag to tooltip trigger to allow clicking through and triggering the tab click event

Ticket

IN-939

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an interaction bug where tooltips on the Overview score tabs prevented tab clicks by allowing click events to pass through the tooltip trigger.

Changes:

  • Added an allowPassThrough prop to the tooltip component and forwarded it to the underlying popover.
  • Added an allowPassThrough prop to the popover component to optionally avoid stopPropagation() on trigger clicks.
  • Wrapped Overview score tab labels with LfxTooltip and enabled pass-through so tab clicks work while the tooltip remains available.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
frontend/app/components/uikit/tooltip/tooltip.vue Adds allowPassThrough prop and forwards it to LfxPopover.
frontend/app/components/uikit/popover/popover.vue Adds allowPassThrough and conditionally stops click propagation on the trigger.
frontend/app/components/modules/project/components/overview/score-details/score-tab-view.vue Wraps tab option content in LfxTooltip and enables pass-through; adds “Learn more” links.
.gitignore Minor formatting + ignores **/AGENTS.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
@emlimlf emlimlf merged commit fcf45e2 into main Feb 4, 2026
10 checks passed
@emlimlf emlimlf deleted the fix/health-score-tooltip branch February 4, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants