fix: tooltip not clickable on overview tab#1645
Merged
Conversation
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an interaction bug where tooltips on the Overview score tabs prevented tab clicks by allowing click events to pass through the tooltip trigger.
Changes:
- Added an
allowPassThroughprop to the tooltip component and forwarded it to the underlying popover. - Added an
allowPassThroughprop to the popover component to optionally avoidstopPropagation()on trigger clicks. - Wrapped Overview score tab labels with
LfxTooltipand enabled pass-through so tab clicks work while the tooltip remains available.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/app/components/uikit/tooltip/tooltip.vue | Adds allowPassThrough prop and forwards it to LfxPopover. |
| frontend/app/components/uikit/popover/popover.vue | Adds allowPassThrough and conditionally stops click propagation on the trigger. |
| frontend/app/components/modules/project/components/overview/score-details/score-tab-view.vue | Wraps tab option content in LfxTooltip and enables pass-through; adds “Learn more” links. |
| .gitignore | Minor formatting + ignores **/AGENTS.md. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/app/components/modules/project/components/overview/score-details/score-tab-view.vue
Outdated
Show resolved
Hide resolved
frontend/app/components/modules/project/components/overview/score-details/score-tab-view.vue
Show resolved
Hide resolved
gaspergrom
approved these changes
Feb 3, 2026
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Signed-off-by: Efren Lim <elim@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Ticket
IN-939