pkg/docker-ce: add vpnkit-expose-port #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,4 @@ | |||
| FROM linuxkit/vpnkit-forwarder:883de832c2c3cb72cd9b01e3f7bd788649e0f2c2 AS vpnkit | |||
There was a problem hiding this comment.
I think its more logical to add this just before FROM scratch so we consistently do the FROM linuxkit/alpine at the top of files.
There was a problem hiding this comment.
Ok - moved and updated
vpnkit-expose-port is the dockerd userland proxy used to expose forwarding ports with vpnkit. This adds the binary to the image in /usr/bin/vpnkit-expose-port, but does not enable it by default. Signed-off-by: Magnus Skjegstad <magnus@skjegstad.com>
MagnusS
force-pushed
the
vpnkit-docker-ce
branch
from
fd6c58c
to
e3a25bb
Compare
justincormack
approved these changes
Jun 15, 2017
|
This needs to update the |
riyazdf
reviewed
Jun 15, 2017
|
@riyazdf thanks! yml files updated |
Signed-off-by: Magnus Skjegstad <magnus@skjegstad.com>
MagnusS
force-pushed
the
vpnkit-docker-ce
branch
from
2e49f37
to
cc59b45
Compare
|
Ah missed one - should be all now |
|
@MagnusS: thanks! I think there's also one more usage in |
|
@riyazdf that was the one I missed - should be in the last update |
|
👍 needed a refresh! All good :) |
justincormack
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vpnkit-expose-port to the docker-ce image.
vpnkit-expose-port is the dockerd userland proxy used to expose
forwarding ports with vpnkit. This adds the binary to the image in
/usr/bin/vpnkit-expose-port, but does not enable it by default.
Signed-off-by: Magnus Skjegstad magnus@skjegstad.com
