Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honour ordering for mixed tests/subgroups #14

Closed
rn opened this issue May 15, 2017 · 0 comments
Closed

Honour ordering for mixed tests/subgroups #14

rn opened this issue May 15, 2017 · 0 comments

Comments

@rn
Copy link
Member

rn commented May 15, 2017

if you have something like:

cases/010_foo/000_bar/test.sh
cases/010_foo/010_baz/000_foobar/test.sh
cases/010_foo/020_foo/test.sh

currently foo.baz.foobar get's executed before foo.bar and foo.foo. It would be good to honour the order when traversing into subgroups
dave-tucker pushed a commit to dave-tucker/rtf that referenced this issue Jun 27, 2017
Fix test sorting for mixed tests/subgroups
7424012 
This PR introduces a TestContainer interface that can be sorted based on
Order. A group now contains a slice of TestContainer instead of a slice
of Groups and Tests. As TestContainer is sortable, a call to sort.Sort
is made before each List or Run command.

Fixes: linuxkit#14

Signed-off-by: Dave Tucker <dt@docker.com>
@dave-tucker dave-tucker mentioned this issue Jun 27, 2017
Merged
dave-tucker pushed a commit to dave-tucker/rtf that referenced this issue Jun 28, 2017
Fix test sorting for mixed tests/subgroups
c2566fd 
This PR introduces a TestContainer interface that can be sorted based on
Order. A group now contains a slice of TestContainer instead of a slice
of Groups and Tests. As TestContainer is sortable, a call to sort.Sort
is made before each List or Run command.

Fixes: linuxkit#14

Signed-off-by: Dave Tucker <dt@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rn