Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the default Cinnamon theme #12364

Merged
merged 27 commits into from
Sep 23, 2024

Conversation

JosephMcc
Copy link
Contributor

Replaces the very outdated default cinnamon theme with something more up-to-date. May still be a few issues here and there that more testing/using will turn up. A few things are also on the roadmap to update style wise. This will set the base for those to come next.

@Initu-Castilhos
Copy link

❤️

@Initu-Castilhos
Copy link

Initu-Castilhos commented Sep 11, 2024

Will it be available for download so can test it?

@JosephMcc
Copy link
Contributor Author

@Initu-Castilhos No it can't be downloaded anywhere. It's part of Cinnamon and I'm not developing it as anything else at the moment.

A couple screenshots of the new dialog styling.
Screenshot from 2024-09-15 20-56-40

Screenshot from 2024-09-15 20-57-08

@JosephMcc
Copy link
Contributor Author

Updated calendar applet styling

Screenshot from 2024-09-15 21-22-48

@Initu-Castilhos
Copy link

Thanks for the reply!

@Initu-Castilhos
Copy link

Will it have the gtk theme and icons too?

@JosephMcc
Copy link
Contributor Author

@Initu-Castilhos No. Cinnamon doesn't include Gtk and icon themes by default. This is just the default cinnamon theme which gets used when you install Cinnamon in distros outside of Mint. Many of those distros don't have a curated Cinnamon version like Mint does.

Modal dialogs will now use the .dialog style class so themes that are not
up-to-date with the new changes will receive styling from the default theme.
This sets us up to properly track the property so we do not have to manually
set and unset the insensitive pseudo class. This will probably have a couple
side effects which will be addressed in further commits.
Many applets use the system-status-icon style class for the panel icon. Make
sure we are setting the proper size for this.
This is needed to show the specific panel being modified from the panel
settings
Use the same hover colors as used in other menus. Add some spacing between
the apps and categories columns. Add some spacing and padding in the
favorites bar
Adds support for :default and :destructive-action buttons in modal dialogs.
Puts them to use in the confirm and polkit dialogs. Also improves the
accent background color.
Add support for event color strips and recolor some of the event titles
There was a bit of fallout from linking a widgets reactivity to it's
sensitive state. Clean that up here and improve the look a bit
Reuse some of the same styling we use in the power applet for the currently
selected and :insensitive item
There isn't enough room for the wider buttons when a notification contains
an image. The text just ends up being ellipsized. Reduce the padding to give
the button text more room
Update to the new style and use a larger border radius on modal dialogs
No real need for this and in some cases ends up being drawn outside of the
switcher background. Just remove it. Clean up the alt-tab theming while at
it.
With 4 rounded corners the menus look better when they aren't touching the
panel or screen edge. Using a margin will create some separation
Use the Cinnamon icon instead of the Linux Mint icon for the start menu
applet. Makes more sense for the default theme
A convenience object we will be using to place things like OSD's on screen
@Initu-Castilhos
Copy link

Can you make the theme's cinnamon.css file available?

@JosephMcc
Copy link
Contributor Author

@Initu-Castilhos In this case it wouldn't do much good. There are actual code changes in the branch to redesign some things. Without those the theme won't work the same. You need to actually build and use the branch.

@Initu-Castilhos
Copy link

@Initu-Castilhos In this case it wouldn't do much good. There are actual code changes in the branch to redesign some things. Without those the theme won't work the same. You need to actually build and use the branch.

Ok!

Gives a new design with the OSD placed at the bottom of the screen. The
styling of the dot indicators is fully themable and can be made to look
however a theme chooses
Gives the OSD a similar style and placement to the new workspace OSD. Uses
a new style class name so themes that don't yet have support will still
get styling. Also adds a new barLevel object that supports volumes above
100 but is still unused for now
@clefebvre clefebvre merged commit f6f05cb into linuxmint:master Sep 23, 2024
3 checks passed
@JosephMcc JosephMcc deleted the new-default-theme branch September 25, 2024 00:56
@Alstruit Alstruit mentioned this pull request Nov 29, 2024
@clefebvre
Copy link
Member

In the source the theme is written in SASS. In the OS once installed you can see the CSS in /usr/share/cinnamon/theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants