sound applet: player icon should not take priority over mute icon #12502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiux
approved these changes
Nov 16, 2024
|
@claudiux Why are you merging commits without discussing them with the team first!! |
|
@leigh123linux I've tested these commits and they work well. It seems to me that the team had other problems to solve. |
|
@claudiux but you don't even know if this was a change that was wanted without any discussion. That's the point. Maybe it was and this is the right solution. But typically that decision is something that is cleared first. |
|
@JosephMcc When a PR solves a problem that has not been closed (cause: unplanned), it seems to me that this PR should be accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12393