Don't crash on start-up if polkit encounters a dbus error #12549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…claimed. Alert the user they may need to disable an alternate agent.
|
Do you have a quick way of reproducing this? |
clefebvre
requested changes
Dec 3, 2024
|
|
||
| Main.warningNotify(_('Unable to start Cinnamon PolicyKit Agent'), err.message + | ||
| "\n\n" + | ||
| _("If you have another PolicyKit Agent configured to autostart, it should be disabled."), |
There was a problem hiding this comment.
should be "agent", not "Agent".
| icon_type: St.IconType.FULLCOLOR, | ||
| icon_size: 36 }); | ||
|
|
||
| Main.warningNotify(_('Unable to start Cinnamon PolicyKit Agent'), err.message + |
There was a problem hiding this comment.
'Unable to start the PolicyKit agent'
|
Actually, I wonder if we should show a dialog or just log the issue... This could be done on purpose by the user to force a GTK agent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #12272
Don't crash if the agent doesn't start properly. If another agent happens to be running, this will throw a DBus exception. I figured popping a notification would be most appropriate, since the user may have another agent configured to auto-start.
This was my best guess at how to handle this. I wasn't sure if it belonged in
polkitAuthenticationAgent.jsor inmain.js.