"toggle location entry" (breadcrumbs) broken with 5.6 updates

[rcrath]

 * Nemo version (nemo --version) 5.6.0
 * Is issue with desktop or windowed nemo? windowed
 * Distribution - (Mint 17.2, Arch, Fedora 25, etc...) Manjaro Cinnamon
 * Graphics hardware *and* driver used "Intel Corporation CoffeeLake-S GT2 [UHD Graphics 630]", "libva-intel-driver 2.4.1-2"
 * 32 or 64 bit 64 bit ```

Issue
For "toggle location entry" (breadcrumbs),

1. Menu item exists but is greyed out
2. Ctrl-L shortcut has no effect
3. preferences / toolbar Toggle Location entry is enabled, but no longer shows on toolbar and does not enable breadcrumbs.
4. proposed removals replaced by "esc" function to return to breadcrumbs does not work and is poorly documented.

It seems that a commonly used workflow item is being changed to address a race condition. Is disabling a feature as basic as this really a viable solution?

commits that break the breadcrumbs function:

• commit [https://github.com/linuxmint/nemo/commit/7ed6889706b24297cf8dfdfe01ada3d64583372a
• commit 0ac19c0
• commit c0fe6ec
• commit ae42620
• commit ccee05a

Steps to reproduce
Attempt to activate pathbar/breadcrumbs/ (toggle location entry)

Expected behaviour
pathbar/breadcrumbs/ (toggle location entry) is default as per settings and can be activated in the usual manners as described above

Other information
If the team deems it necessary to break this basic feature, then at the very least, the menus need to be cleaned up and the new behavior documented better than the cryptic and inaccurate (as in not descriptive of any actual behavior) comments to the commits before releasing this. But please — restore this feature; it is simple, useful, and not broken until said commits broke it.

[mtwebster]

This was deliberate. Prior to this, you were permanently in one or the other mode.

I prefer the breadcrumbs bar. But sometimes I want to enter a path. Before this, my workflow was:

• Hit ctrl-L, press the toolbar button, or in the icon view, I could hit /.
• Enter my path, hit enter.
• I want my pathbar back, I have to either click the toolbar button again, or hit ctrl-L twice

It could also be inconvenient for someone who used location entry ordinarily - toggling away required a double-shortcut to return to the breadcrumbs bar.

Now, if I have to enter a path manually:

• Click the current location's breadcrumb, hit ctrl-L, press the toolbar button or hit / (in any type of view)
• Enter my path, hit enter
• My pathbar automatically comes back, no extra effort.

For someone who prefers location entry, the thought was there's no need to toggle to the pathbar, and it can be disabled.

Entering a path manually requires no more effort than it did previously.

We try to consider what's the best behavior for the most people - it was subpar in previous versions - and felt this was a pretty good solution and familiar behavior to many people.

I'm not sure what's so confusing about the commit messages. Fixing a race condition was to improve an implementation detail of the original feature commit.

Can you describe what workflow we're breaking for you? Is the new default pathbar mode not usable?

[rcrath]

Thanks for responding @mtwebster

This was deliberate. Prior to this, you were permanently in one or the other mode.
8< ....... 8<
Can you describe what workflow we're breaking for you? Is the new default pathbar mode not usable?

I have attached a short screen recording so you can see how it is not working on my machine. plz remember to turn audio on for explanation:

nemo_no_breadcrumbs-2022-12-12_18.12.23.mp4

[rcrath]

maybe fixed in linuxmint/mint21.1-beta#73 (comment) ? hope it drifts downstream quickly if so ;)