[Next] Fix docs meson option #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error like: help/reference/libview/meson.build:13:18: ERROR: Unknown variable "libdoc_deps"
Fix error: help/reference/libview/meson.build:16:6: ERROR: gnome.gtkdoc got unknown keyword arguments "cflags"
It fixes error help/reference/shell/meson.build:16:6: ERROR: gnome.gtkdoc got unknown keyword arguments "cflags"
|
Faced also with this one #549 |
Static libs are ignored for gtkdoc. The trick here is to build both static and dynamic, use static in the same place as before and use dynamic for doc. Also remove uneeded parts of declare_dependency in help/reference/shell/meson.build and add proper src_dir later.
|
I looked into the code (mesonbuild/modules/gnome.py) it seems like there is no way to pass a static lib (libshell) into gnome.gtkdoc. The fix is to compile both and pass each lib type where needed. |
|
@clefebvre can you take a look please? |
timp87
force-pushed
the
fix-docs-meson-option
branch
from
c97d2a4 to
ac5e12a
Compare
I'm not sure I'm doing here everything right, so it's just my assumption: The header I migrate from libview_private_headers to libview_headers are used in the documentation. Also they do not have this inside: #if !defined (XREADER_COMPILATION) #error "This is a private header." #endif like other private header do (libview/ev-link-accessible.h) for example. So if I'm wrong and the headers I move are really private then: - they should have this "error "This is a private header." listed above as well - they should be removed from xml to generate doc for shell
timp87
force-pushed
the
fix-docs-meson-option
branch
from
ac5e12a to
c2a0583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple issues if you try to build xreader with docs option set