Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ This file doesn't exist. - Also, there is no
readme-vars.yml
, so I made my changes directly in the READMEDescription:
This fixes the deprecated
sync
(#8) and adds an option to disable thewatch
command (#9).Benefits of this PR and context:
Even though the
watch
command is the main goal of this repo, there is now an option to opt-out (#9).Also, the deprecated command is migrated (#8).
How Has This Been Tested?
Tested directly
Tested it with directly modifying the container and killing the original service:
(Screenshot taken at 10:32, for timestamp references.)
Tested with own image
Tested before with image
rala72/plextraktsync-test
(on the screenshot, thesleep infinity is missing
):Conclusion
both test show the expected log line, if I create a
NO_WATCH
fileare these tests sufficient?
otherwise, does someone have an idea why simply running the docker file results in this bash error or how to fix it?
Source / References:
Issues: #8, #9
https://discord.com/channels/354974912613449730/1226189951490854932/1226189951490854932