Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #8 and #9 #10

Closed
wants to merge 2 commits into from
Closed

Resolve #8 and #9 #10

wants to merge 2 commits into from

Conversation

rala72
Copy link

@rala72 rala72 commented Apr 6, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

^ This file doesn't exist. - Also, there is no readme-vars.yml, so I made my changes directly in the README


Description:

This fixes the deprecated sync (#8) and adds an option to disable the watch command (#9).

Benefits of this PR and context:

Even though the watch command is the main goal of this repo, there is now an option to opt-out (#9).
Also, the deprecated command is migrated (#8).

How Has This Been Tested?

Tested directly

Tested it with directly modifying the container and killing the original service:
image
(Screenshot taken at 10:32, for timestamp references.)

Tested with own image

Tested before with image rala72/plextraktsync-test (on the screenshot, the sleep infinity is missing):
image

if I run it manually it works, but I don't really get the two logs above - seems like a normal dockerfile build is building the image in a different way or so?
also, the first line is from a different folder which I haven't touched; not sure about the second line
and I haven't found my echo in the container startup protocol 🤔

Conclusion

both test show the expected log line, if I create a NO_WATCH file

are these tests sufficient?
otherwise, does someone have an idea why simply running the docker file results in this bash error or how to fix it?

Source / References:

Issues: #8, #9
https://discord.com/channels/354974912613449730/1226189951490854932/1226189951490854932

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@rala72 rala72 closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant