Skip to content

Conversation

@mKeRix
Copy link
Contributor

@mKeRix mKeRix commented May 10, 2020

linuxserver.io


We welcome all PR’s though this doesn’t guarantee it will be accepted.

Description:

Added info about the ffmpeg mod to the README as requested.

Benefits of this PR and context:

LazyLibrarian has added support to do conversion and tagging of audiobooks which requires ffmpeg to be available on the system. This mod installs it into the container on startup, which makes the conversion features functional. Closes #45.

How Has This Been Tested?

Enabled on personal LazyLibrarian instance, running on Docker 19.03.8/Ubuntu. ffmpeg is installed and recognized by LazyLibrarian.

Source / References:

Original PR for the new mod: linuxserver/docker-mods#38

Enables LazyLibrarian audiobook conversion features.

Closes #45.
@CHBMB
Copy link
Contributor

CHBMB commented May 10, 2020

@mKeRix Sorry to keep asking you to do more work, but all our README.md files are generated from the readme-vars.yml file, so unfortunately the changes you've made would be overwritten once the image is updated by Jenkins.

If you're happy to make the changes to readme-vars.yml then that would be awesome, if not let me know and I can submit a PR.

https://github.com/linuxserver/docker-lazylibrarian/blob/master/readme-vars.yml

@mKeRix
Copy link
Contributor Author

mKeRix commented May 10, 2020

Oh sorry, didn't see that. Will revert the README and change the vars now. Thanks for the heads up!

@mKeRix
Copy link
Contributor Author

mKeRix commented May 10, 2020

I migrated the content from the README to readme-vars, if I can improve the texts somehow feel free to let me know. I'm not sure what caused the PR build to fail though - it doesn't look like the step that failed used the readme-vars in anyway.

@mKeRix
Copy link
Contributor Author

mKeRix commented May 28, 2020

@CHBMB Anything I can do to push this PR along further? :)

@thelamer thelamer merged commit 8702f31 into linuxserver:master Jul 17, 2020
@mKeRix mKeRix deleted the patch-1 branch March 2, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: FFMPEG capabilities

4 participants