Skip to content

Conversation

@labmonkey
Copy link

This PR pretty much fixes #789
But it is also so much more:

  • Refactored whole code so that its not such a mess
  • Updated documentation so that it explains better how the mod works, requirements, setting up labels and notifications
  • Reduced number of API calls when swag container restarts
  • Added better support for setting up notifications and fixed issue with default notifications not being applied
  • Fixed an issue with mod crashing when there were Manually added monitors in Uptime Kuma
  • Fixed an issue with labels that container numeric values
  • Added basic support for Monitor Groups
  • More log messages so that its easier to grasp what is happening
  • Fixed a crash when mod was executed while uptime kuma was not running (mod just gently stops now)

enjoy

aptalca and others added 7 commits January 24, 2024 18:20
- Updated documentation so that it explains better how the mod works, requirements, setting up labels and notifications
- Reduced number of API calls when swag container restarts
- Added better support for setting up notifications and fixed issue with default notifications not being applied
- Fixed an issue with mod crashing when there were Manually added monitors in Uptime Kuma
- Fixed an issue with labels that container numeric values
- Added basic support for Monitor Groups
- More log messages so that its easier to grasp what is happening
- Fixed a crash when mod was executed while uptime kuma was not running (mod just gently stops now)
@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_866

@labmonkey
Copy link
Author

I've used the ghcr.io/linuxserver/mods:pull_request_866 build and it works!

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@labmonkey
Copy link
Author

Any chance for this to be reviewed and merged?

@aptalca
Copy link
Member

aptalca commented Apr 18, 2024

Sorry, I saw this when first opened, then totally forgot about it. Reviewing now

@aptalca aptalca self-assigned this Apr 18, 2024
@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_866

@labmonkey labmonkey requested a review from aptalca April 21, 2024 11:49
@aptalca aptalca merged commit 070873e into linuxserver:swag-auto-uptime-kuma Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants