Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man: remove texts related to InputDevice #345

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

flying-elephant
Copy link
Contributor

Since xorg fully started to rely on hotplugging over decade, modern tablet devices can be automatically detected. This commit removes "Section InputDevice" related texts, which is used when hotplugging is disabled.

This changed is related to the issue #339.

Since xorg fully started to rely on hotplugging over decade,
modern tablet devices can be automatically detected.
This commit removes "Section InputDevice" related texts, which
is used when hotplugging is disabled.

Signed-off-by: Tatsunosuke Tobita <tatsunosuke.tobita@wacom.com>
@flying-elephant flying-elephant requested a review from whot June 10, 2024 23:29
Copy link
Member

@whot whot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, a few minor nitpicks, I'd appreciate it if you could address those.

man/wacom.man Outdated Show resolved Hide resolved
man/wacom.man Show resolved Hide resolved
man/wacom.man Outdated Show resolved Hide resolved
flying-elephant and others added 3 commits June 11, 2024 17:30
Co-authored-by: Peter Hutterer <peter.hutterer@who-t.net>
Co-authored-by: Peter Hutterer <peter.hutterer@who-t.net>
This change adds "The" in front of "InputClass" at the beginning of "DRIVER-INTERNAL DEVICE HOTPLUGGING" section. Also, it replaces all "5X' to "5" to describe the proper references.
@whot whot merged commit bc795e9 into linuxwacom:master Jun 12, 2024
13 checks passed
@whot
Copy link
Member

whot commented Jun 12, 2024

thanks, squashed and merged.

for the future - you can squash review comments into the original commit(s) where applicable. github.com steers you to a commit + merge request but that's wrong for most project, it's better to have a clean commit message log. So for things where you do e.g. a typo fix it's best to do an interactive rebase (google it :) and squash it in, followed by a force push to your branch. This is doubly important where there are multiple logical changes in a single MR because the github UI only lets you either squash them all together into one commit (bad) or leave them as disjointed "fix up blah" commits (also bad).

@flying-elephant
Copy link
Contributor Author

I understand. I'll keep it in mind:)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants