Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should NEVER add wechaty as a dependence for the Puppet Provider(such as wechaty-puppet-ioscat) #12

Open
huan opened this issue Aug 29, 2018 · 1 comment
Open

We should NEVER add wechaty as a dependence for the Puppet Provider(such as wechaty-puppet-ioscat) #12

huan opened this issue Aug 29, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@huan
Copy link
Collaborator

huan commented Aug 29, 2018

This will cause very strange bugs like wechaty/wechaty#1573

Wechaty might consider to enforce it by add unit testing to make sure this will not happen.
@huan huan added the bug Something isn't working label Aug 29, 2018
huan added a commit that referenced this issue Aug 29, 2018
@huan
remove wechaty dependence (#12)
b432bd5
@huan
Copy link
Collaborator Author

huan commented Aug 29, 2018

@linyimin-bupt I'll leave this issue to you, please help yourself to close it after you read and make sure you understand that this will be a big problem for us.

huan added a commit that referenced this issue Aug 29, 2018
@huan
remove wechaty dependence (#12)
af75c29
@huan huan mentioned this issue Aug 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan