Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attempt to remove slivers by dropping small polygons TDE-1130 #1119

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

blacha
Copy link
Member

@blacha blacha commented Oct 22, 2024

Motivation

Quite a few of our datasets are aligned to a EPSG:2193 tile grid, when reprojecting these area polygons to a EPSG:4326, small slithers can appear

for example in this dataset where one dataset (magenta) has 5 tiles across and one has 4 (blue) only the two corner points are stored

image (41)

As you zoom in on the corner slithers appear

image (42)

Modification

Find polygons that are very small and drop them.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@dwsilk dwsilk changed the title feat: attempt to remove slithers by dropping small datasets TDE-1130 feat: attempt to remove slivers by dropping small datasets TDE-1130 Oct 23, 2024
@paulfouquet paulfouquet added the container Build a container from a pull request label Oct 23, 2024
@blacha blacha marked this pull request as ready for review October 31, 2024 20:36
@blacha blacha requested review from a team as code owners October 31, 2024 20:36
@blacha blacha changed the title feat: attempt to remove slivers by dropping small datasets TDE-1130 feat: attempt to remove slivers by dropping small polygons TDE-1130 Nov 4, 2024
@paulfouquet paulfouquet added container Build a container from a pull request and removed container Build a container from a pull request labels Nov 4, 2024
@dwsilk
Copy link
Member

dwsilk commented Nov 11, 2024

Outputs from this process look great to me!

@dwsilk dwsilk added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit aa1f931 Nov 11, 2024
3 checks passed
@dwsilk dwsilk deleted the feat/remove-slithers branch November 11, 2024 20:42
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


## [4.8.0](v4.7.0...v4.8.0)
(2024-11-12)


### Features

* attempt to remove slivers by dropping small polygons TDE-1130
([#1119](#1119))
([aa1f931](aa1f931))
* generate initial collection-related STAC metadata TDE-1300
([#1124](#1124))
([e30dff9](e30dff9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Build a container from a pull request
Development

Successfully merging this pull request may close these issues.

4 participants