feat(group): increase logging for grouping #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amfage
approved these changes
Aug 17, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
🤖 I have created a release *beep* *boop* --- ## [2.13.0](v2.12.0...v2.13.0) (2023-09-05) ### Features * **cli:** Move the basemaps github create-pr cli into argo-tasks. BM-872 ([#627](#627)) ([a47b38a](a47b38a)) * **group:** increase logging for grouping ([#609](#609)) ([2966586](2966586)) ### Bug Fixes * **copy:** copy and fix content-types TDE-859 ([#633](#633)) ([cc7c5cc](cc7c5cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When artifact errors occur in argo its hard to figure out exactly what files were written and what is in those files.
Description
This increases the logging to explain exactly which files were written and some information about their contents.
When running argo containers having the exact github action that made the container is very useful, we were loosing the -attempt number so it was not possible to get the exact version number.