fix(lambda-tiler): corrected conditional logic

linz · Oct 24, 2024 · 0cb7768 · 0cb7768
1 parent 8304f90
commit 0cb7768
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/attribution/src/attribution.ts b/packages/attribution/src/attribution.ts
@@ -202,7 +202,7 @@ export class Attribution {
     const attribution = createLicensorAttribution(providers);
     const list = this.renderList(filtered);
 
-    if (list.length) {
+    if (list.length > 0) {
       return `${attribution} - ${list}`;
     } else {
       return attribution;

diff --git a/packages/lambda-tiler/src/routes/attribution.ts b/packages/lambda-tiler/src/routes/attribution.ts
@@ -239,11 +239,11 @@ export async function createTileSetAttribution(
 
   // ensure imagery exist for the given projection
   const imgId = tileSet.layers[0][projection.code];
-  if (imgId === undefined) return '';
+  if (imgId == null) return '';
 
   // attempt to load the imagery
   const imagery = await provider.Imagery.get(imgId);
-  if (imagery == null || imagery.providers == null) {
+  if (imagery?.providers == null) {
     return createLicensorAttribution();
   }
 

diff --git a/packages/landing/src/attribution.ts b/packages/landing/src/attribution.ts
@@ -167,7 +167,7 @@ export class MapAttribution implements maplibre.IControl {
     Config.map.emit('visibleLayers', filteredLayerIds);
 
     const attributionHTML = attr.renderLicense(filtered);
-    this.setAttribution(attributionHTML ?? '');
+    this.setAttribution(attributionHTML);
   };
 
   setAttribution(text: string): void {