Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landing): Add new features pop up to alert users for recent releases. BM-1064 #3356

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

Wentao-Kuang
Copy link
Contributor

Motivation

We want to alert Basemaps users about new features for recent release. To use the @linzjs/lui -> LuiUpdatesSplashModal which is same with land online search.

Modifications

Initial investigations with @linzjs/lui that it's very hard to import and use react components from it because different tech stacks.

  • lui build and bundled with nodejs which contains dependencies like crypto or stream that is not support by browser. We might need to do polyfills to map them into browser friendly dependencies.
  • lui only bundle everything into one index.js, we don't have individual module file to do direct import, so we have to deal with dependency problem above.

As a result, we decide to re-implement the LuiUpdatesSplashModal in basemaps just using the assets and css from @linzjs/lui

  • FeatureUpdates is a completely re-implementation of LuiUpdatesSplashModal
  • NewFeature is the component that we need to update often when describe new features.
  • Updated @linzjs/lui to latest

Verification

  • Tested new pop up only show once after dismissed.
  • Tested new pop up stop showing after closing date.
  • Tested new pop up shows in incognito mode/clearing cache after dismissed.
    image
    image

@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner October 7, 2024 04:01
@Wentao-Kuang Wentao-Kuang requested a review from blacha October 8, 2024 01:12
tawera-manaena
tawera-manaena previously approved these changes Oct 10, 2024
@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Oct 10, 2024
Merged via the queue into master with commit a61b652 Oct 10, 2024
10 of 11 checks passed
@Wentao-Kuang Wentao-Kuang deleted the feat/feature-updates branch October 10, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants