Skip to content

Commit

Permalink
test: Poetry on Windows
Browse files Browse the repository at this point in the history
Works around flaky temporary directory removal on Windows
<python-poetry/poetry-core#460>.
  • Loading branch information
l0b0 committed Jan 20, 2023
1 parent d2f036b commit 992ce59
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
19 changes: 18 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ jobs:
runner:
- macos-12
- ubuntu-22.04
- windows-2022
python:
- "3.8"
- "3.9"
Expand All @@ -76,6 +77,8 @@ jobs:
pip-cache-dir: ~/Library/Caches/pip
- runner: ubuntu-22.04
pip-cache-dir: ~/.cache/pip
- runner: windows-2022
pip-cache-dir: ~\AppData\Local\pip\Cache
steps:
- name: Check out repository
uses: actions/checkout@v3.3.0
Expand Down Expand Up @@ -104,6 +107,7 @@ jobs:
run:
echo "GDAL_VERSION=$(poetry show gdal | tr -d ' ' | grep '^version:' |
cut -d ':' -f 2)" >> $GITHUB_ENV
shell: bash
working-directory: flooding/sentinel2_water_extraction

- name: Setup Conda
Expand All @@ -117,9 +121,22 @@ jobs:
conda install --channel=conda-forge --quiet --yes gdal=${{
env.GDAL_VERSION }} poetry

- name: Install Python packages
- name: Install Python packages on non-Windows runner
run: poetry install --only=main --no-root
working-directory: flooding/sentinel2_water_extraction
if: ${{ !startsWith(runner.os, 'Windows') }}

- name:
Install Python packages on Windows runner (Workaround for
https://github.com/python-poetry/poetry/issues/1031)
uses: nick-fields/retry@v2.8.3
with:
timeout_minutes: 9999 # Workaround for https://github.com/nick-fields/retry/issues/107
max_attempts: 6
command: cd flooding/sentinel2_water_extraction && poetry install
--only=main --no-root # Workaround for https://github.com/python-poetry/poetry/issues/7363 / https://github.com/nick-fields/retry/issues/89
shell: bash
if: ${{ startsWith(runner.os, 'Windows') }}

- name: Run test
run:
Expand Down
3 changes: 2 additions & 1 deletion flooding/sentinel2_water_extraction/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ Below are the instructions to get the Notebook up and running

## Prerequisites

- Linux (tested on Ubuntu 22.04) or macOS (tested on version 12, Monterey)
- Linux (tested on Ubuntu 22.04), macOS (tested on version 12, Monterey), or
Windows (tested on Windows Server 2022)
- Python 3.8, 3.9, or 3.10
- GDAL 3.4

Expand Down

0 comments on commit 992ce59

Please sign in to comment.