Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Poetry on MacOS #115

Merged
merged 2 commits into from
Jan 18, 2023
Merged

test: Poetry on MacOS #115

merged 2 commits into from
Jan 18, 2023

Conversation

l0b0
Copy link
Collaborator

@l0b0 l0b0 commented Jan 16, 2023 •
edited
Loading

@l0b0 l0b0 force-pushed the test/macos branch 3 times, most recently from 50dcaec to 40fa8bd Compare January 17, 2023 00:42
@l0b0 l0b0 marked this pull request as ready for review January 17, 2023 00:57
@l0b0 l0b0 added the automerge label Jan 17, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 17, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Jan 17, 2023
mfwightman
mfwightman previously approved these changes Jan 17, 2023
View reviewed changes
@l0b0 l0b0 force-pushed the test/macos branch 11 times, most recently from 5907854 to 2ee1ab4 Compare January 18, 2023 00:48
@l0b0 l0b0 requested a review from mfwightman January 18, 2023 00:48
@l0b0 l0b0 added the automerge label Jan 18, 2023
@kodiakhq kodiakhq bot removed the automerge label Jan 18, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 18, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

mfwightman
mfwightman previously approved these changes Jan 18, 2023
View reviewed changes
@l0b0
refactor: Pull out command to get GDAL version
c2732d0 
Easier to read, and reusable.
@l0b0
test: Poetry on macOS
935786f 
Use short options for `tr` and `cut`, for compatibility with the macOS
tools.

Installing GDAL with Conda is one of the few cross-platform installation
methods available:

- GDAL 3.4.1 is not available for installation with brew
  <https://formulae.brew.sh/formula/gdal>.
- Poetry ignores declaration of different versions for macOS and Linux
  <python-poetry/poetry#5506>.

Unfortunately Conda does not yet support Python 3.11
<conda/conda#11170>, so I've dropped that.
@l0b0 l0b0 merged commit 344a796 into master Jan 18, 2023
@l0b0 l0b0 deleted the test/macos branch January 18, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfwightman mfwightman mfwightman left review comments

@billgeo billgeo Awaiting requested review from billgeo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0b0 @mfwightman