Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

feat: Implement validation summary task #401

Merged
merged 9 commits into from
Mar 16, 2021
Merged

feat: Implement validation summary task #401

merged 9 commits into from
Mar 16, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Mar 14, 2021 •
edited
Loading

Challenges:

Prep/related work:

@l0b0 l0b0 force-pushed the feat/implement-validation-summary-task branch 2 times, most recently from 879d0dc to 88f3722 Compare March 15, 2021 03:38
@l0b0 l0b0 added the enhancement New feature or request label Mar 15, 2021
@l0b0 l0b0 marked this pull request as ready for review March 15, 2021 03:38
@l0b0 l0b0 force-pushed the feat/implement-validation-summary-task branch 3 times, most recently from fb63662 to 555d432 Compare March 15, 2021 22:44
@l0b0 l0b0 added the automerge label Mar 15, 2021
@l0b0 l0b0 mentioned this pull request Mar 15, 2021
Merged
@l0b0 l0b0 force-pushed the feat/implement-validation-summary-task branch from 555d432 to a85427f Compare March 15, 2021 23:52
@kodiakhq kodiakhq bot removed the automerge label Mar 16, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 16, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

MitchellPaff
MitchellPaff reviewed Mar 16, 2021
View reviewed changes
tests/test_processing_stack.py

assert execution["status"] == "SUCCEEDED", execution

# Then the files should not be copied
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be asserted in a subtest?

@l0b0 l0b0 force-pushed the feat/implement-validation-summary-task branch 2 times, most recently from b984493 to 00bc0b0 Compare March 16, 2021 01:14
@l0b0 l0b0 force-pushed the feat/implement-validation-summary-task branch from 00bc0b0 to a9bf32f Compare March 16, 2021 01:28
@l0b0 l0b0 requested a review from MitchellPaff March 16, 2021 01:31
@l0b0 l0b0 added the automerge label Mar 16, 2021
@kodiakhq kodiakhq bot merged commit facd1e3 into master Mar 16, 2021
@kodiakhq kodiakhq bot deleted the feat/implement-validation-summary-task branch March 16, 2021 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MitchellPaff MitchellPaff MitchellPaff approved these changes

@imincik imincik Awaiting requested review from imincik

Assignees
No one assigned
Labels
automerge enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0b0 @MitchellPaff