feat: replace remaining non-examples with unit tests

extensions/aerial-photo/tests/aerial_photo_item.test.js

@@ -0,0 +1,103 @@
+import o from 'ospec';
+import Ajv from 'ajv';
+import { dirname, join } from 'path';
+import { fileURLToPath } from 'url';
+import { promises as fs } from 'fs';
+import { AjvOptions } from '../../validation.js';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const schemaPath = join(__dirname, '..', 'schema.json');
+const exampleItemPath = join(__dirname, '..', 'examples/item.json');
+
+o.spec('aerial-photo-item', () => {
+  let validate;
+  const ajv = new Ajv(AjvOptions);
+
+  o.before(async () => {
+    const data = JSON.parse(await fs.readFile(schemaPath));
+    validate = await ajv.compileAsync(data);
+  });
+
+  o('Item should pass validation', async () => {
+    // given
+    const aerialPhotoItemExample = JSON.parse(await fs.readFile(exampleItemPath));
+
+    // when
+    let valid = validate(aerialPhotoItemExample);
+
+    // then
+    o(valid).equals(true)(JSON.stringify(validate.errors, null, 2));
+  });
+
+  o("Item with an incorrect 'aerial-photo:run' field should fail validation", async () => {
+    // given
+    const aerialPhotoItemExample = JSON.parse(await fs.readFile(exampleItemPath));
+    aerialPhotoItemExample.properties['aerial-photo:run'] = 1234;
+
+    // when
+    let valid = validate(aerialPhotoItemExample);
+
+    // then
+    o(valid).equals(false);
+    o(
+      validate.errors.some(
+        (error) => error.dataPath === ".properties['aerial-photo:run']" && error.message === 'should be string',
+      ),
+    ).equals(true)(JSON.stringify(validate.errors));
+  });
+
+  o("Item without the mandatory 'aerial-photo:run' field should fail validation", async () => {
+    // given
+    const aerialPhotoItemExample = JSON.parse(await fs.readFile(exampleItemPath));
+    delete aerialPhotoItemExample.properties['aerial-photo:run'];
+
+    // when
+    let valid = validate(aerialPhotoItemExample);
+
+    // then
+    o(valid).equals(false);
+    o(
+      validate.errors.some(
+        (error) =>
+          error.dataPath === '.properties' && error.message === "should have required property '['aerial-photo:run']'",
+      ),
+    ).equals(true)(JSON.stringify(validate.errors));
+  });
+
+  o("Item without a mandatory 'aerial-photo:sequence_number' field should fail validation", async () => {
+    // given
+    const aerialPhotoItemExample = JSON.parse(await fs.readFile(exampleItemPath));
+    delete aerialPhotoItemExample.properties['aerial-photo:sequence_number'];
+
+    // when
+    let valid = validate(aerialPhotoItemExample);
+
+    // then
+    o(valid).equals(false);
+    o(
+      validate.errors.some(
+        (error) =>
+          error.dataPath === '.properties' &&
+          error.message === "should have required property '['aerial-photo:sequence_number']'",
+      ),
+    ).equals(true)(JSON.stringify(validate.errors));
+  });
+
+  o("Item with an incorrect 'aerial-photo:sequence_number' field should fail validation", async () => {
+    // given
+    const aerialPhotoItemExample = JSON.parse(await fs.readFile(exampleItemPath));
+    aerialPhotoItemExample.properties['aerial-photo:sequence_number'] = 'incorrect_example';
+
+    // when
+    let valid = validate(aerialPhotoItemExample);
+
+    // then
+    o(valid).equals(false);
+    o(
+      validate.errors.some(
+        (error) =>
+          error.dataPath === ".properties['aerial-photo:sequence_number']" && error.message === 'should be integer',
+      ),
+    ).equals(true)(JSON.stringify(validate.errors));
+  });
+});

extensions/camera/tests/camera.test.js

@@ -20,26 +20,29 @@ o.spec('camera', () => {
 
   o('camera-validates-successfully', async () => {
     // given
-    const camera_item_example = JSON.parse(await fs.readFile(examplePath));
+    const cameraItemExample = JSON.parse(await fs.readFile(examplePath));
 
     // when
-    let valid = validate(camera_item_example);
+    let valid = validate(cameraItemExample);
 
     // then
     o(valid).equals(true)(JSON.stringify(validate.errors, null, 2));
   });
 
-  o('camera-validation-fails', async () => {
+  o("Item with an incorrect 'camera:sequence_number' field should fail validation", async () => {
     // given
-    const camera_item_example = JSON.parse(await fs.readFile(examplePath));
-    camera_item_example.properties['camera:sequence_number'] = 'incorrect_value';
+    const cameraItemExample = JSON.parse(await fs.readFile(examplePath));
+    cameraItemExample.properties['camera:sequence_number'] = 'incorrect_value';
 
     // when
-    let valid = validate(camera_item_example);
+    let valid = validate(cameraItemExample);
 
     // then
     o(valid).equals(false);
-    o(validate.errors.length).equals(1);
-    o(validate.errors[0].message).equals('should be integer');
+    o(
+      validate.errors.some(
+        (error) => error.dataPath === ".properties['camera:sequence_number']" && error.message === 'should be integer',
+      ),
+    ).equals(true)(JSON.stringify(validate.errors));
   });
 });