Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a lambda function that would be nice to end-to-end test. It functions as a proxy and receives a URL, resolves it to an IP address and then returns the response to the client. The existing tests use
mockito
for the HTTP responses and point directly to the server, but it would be good to test the DNS resolution in the mix as well.In essence, it would be nice to do something like:
This will then resolve
example.com
into the address of themockito
server before making the request to the mock and handling the response.However,
mockito
doesn't currently expose the address of the server in a nice format. While the socket address likely could just be parsed withSocketAddr::from_str
on the result ofhost_with_port
, it makes more sense to expose theSocketAddr
directly (and begin passing it around instead ofString
).This change:
Server
type to store aSocketAddr
instead of aString