Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-focus the search field #46

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Auto-focus the search field #46

merged 1 commit into from
Dec 17, 2024

Conversation

ianh
Copy link
Contributor

@ianh ianh commented Dec 14, 2024

This lets you type right away when you load the page rather than having to click the field or navigate to it using the tab key.

This lets you type right away when you load the page rather than having to click the field or navigate to it using the tab key.
@TheOnlyTails
Copy link
Member

You can already focus on search with / so i don't see the issue

@ianh
Copy link
Contributor Author

ianh commented Dec 14, 2024

At least for me, when I visit the page, my goal is to search for a word. Websites where you primarily search for things (like Google, dictionary.com, etc.) autofocus the field to make this easier.

@TheOnlyTails
Copy link
Member

@AcipenserSturio @gregdan3 thoughts?

@AcipenserSturio
Copy link
Member

Yea autofocus is better than the undiscoverable / shortcut. Autofocus messes with tab-navigation but that was never explicitly stated to be a priority, as evidenced by the lack of a "Jump to content" element (c.f. https://old.reddit.com/)

@TheOnlyTails
Copy link
Member

I didn't add a Jump to Content element because there's like 5 elements in before the actual content
but I do agree it could be nice

@TheOnlyTails TheOnlyTails merged commit 7d2c966 into lipu-linku:main Dec 17, 2024
@ianh ianh deleted the patch-1 branch December 17, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants