Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meinberlin/apps/bplan: added start and enddate of plan to required fo… #3993

Conversation

sabinammm
Copy link
Contributor

@sabinammm sabinammm commented Nov 29, 2021

…r publication

fixes #3991

In Bplans the required field start-date & end-date of project are not marked as required for publication:
Untitled

see also bplan form on DEV

So that the form_field.html in the a4dashboard can render these accordingly, these fields need to be added to the form meta class of bplans.

@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 3.14% 39/1242
🔴 Branches 2.93% 21/716
🔴 Functions 4.15% 17/410
🔴 Lines 6.79% 248/3654

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 6112ab0

@fuzzylogic2000
Copy link
Contributor

This is ready, right? Because you did not ask for reviews...

@sabinammm
Copy link
Contributor Author

sabinammm commented Nov 30, 2021

This is ready, right? Because you did not ask for reviews...

Yes, I simply forgot - thanks for the review!

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@fuzzylogic2000 fuzzylogic2000 merged commit f75d417 into main Nov 30, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the sm-2021-11-29-update-bplans-required-fields-for-publication branch November 30, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Bplans required field (start-date & end-date) for publication is not marked as such
2 participants