apps/documents: loading document js only in template, not globally to… #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reduce chunk size
philli-m
commented
Dec 1, 2021
| } | ||
|
|
||
| document.addEventListener('DOMContentLoaded', init, false) | ||
| document.addEventListener('a4.embed.ready', init, false) |
There was a problem hiding this comment.
do we think having an init file is a good solution?
philli-m
commented
Dec 1, 2021
| }, | ||
| unload_warning: { | ||
| import: './meinberlin/assets/js/unload_warning.js' | ||
| }, |
There was a problem hiding this comment.
this gets ride of the annoying console errors finally, I think it's because these need to be initialised right away and do not have dependencies in adhocracy4.js but I don't know for sure
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 5228666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… reduce chunk size