Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks 2021 11 add token form to proposal list view #4020

Merged
merged 4 commits into from
Dec 3, 2021

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Dec 2, 2021

This adds a form for the voting token to the proposal list. When the token is there, it simply displayed for now, we will then need a react component for showing the left votes (I will next add that to the api).
Oh, and we also need a widget for the token, so that it can be entered with 3 x 4 characters.

@Rineee Rineee changed the title Ks 2021 11 add votes rules and views WIP Ks 2021 11 add token form to proposal list view Dec 2, 2021
@Rineee Rineee force-pushed the ks-2021-11-add-votes-rules-and-views branch from cfdea86 to b88d78b Compare December 2, 2021 14:45
@Rineee Rineee force-pushed the ks-2021-11-add-votes-rules-and-views branch from b88d78b to cd99083 Compare December 2, 2021 14:49
@Rineee Rineee changed the title WIP Ks 2021 11 add token form to proposal list view Ks 2021 11 add token form to proposal list view Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 4.49% 56/1247
🔴 Branches 3.34% 24/718
🔴 Functions 5.6% 23/411
🔴 Lines 7.93% 291/3670

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 2a42b82

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a tinsi tiny thing. :)

meinberlin/apps/votes/models.py Outdated Show resolved Hide resolved
@Rineee Rineee force-pushed the ks-2021-11-add-votes-rules-and-views branch from cd99083 to 2a42b82 Compare December 3, 2021 10:56
@Rineee Rineee requested a review from fuzzylogic2000 December 3, 2021 10:56
@fuzzylogic2000 fuzzylogic2000 merged commit fabde43 into main Dec 3, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2021-11-add-votes-rules-and-views branch December 3, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants