-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ks 2021 11 add token form to proposal list view #4020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rineee
changed the title
Ks 2021 11 add votes rules and views
WIP Ks 2021 11 add token form to proposal list view
Dec 2, 2021
Rineee
force-pushed
the
ks-2021-11-add-votes-rules-and-views
branch
from
December 2, 2021 14:45
cfdea86
to
b88d78b
Compare
Rineee
force-pushed
the
ks-2021-11-add-votes-rules-and-views
branch
from
December 2, 2021 14:49
b88d78b
to
cd99083
Compare
Rineee
commented
Dec 2, 2021
Rineee
changed the title
WIP Ks 2021 11 add token form to proposal list view
Ks 2021 11 add token form to proposal list view
Dec 2, 2021
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 2a42b82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just a tinsi tiny thing. :)
Rineee
force-pushed
the
ks-2021-11-add-votes-rules-and-views
branch
from
December 3, 2021 10:56
cd99083
to
2a42b82
Compare
fuzzylogic2000
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a form for the voting token to the proposal list. When the token is there, it simply displayed for now, we will then need a react component for showing the left votes (I will next add that to the api).
Oh, and we also need a widget for the token, so that it can be entered with 3 x 4 characters.