Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/maps: rm map files to a4 and update imports and deps #4021

Merged
merged 2 commits into from
Dec 9, 2021
Merged

apps/maps: rm map files to a4 and update imports and deps #4021

merged 2 commits into from
Dec 9, 2021

Conversation

philli-m
Copy link
Contributor

@philli-m philli-m commented Dec 2, 2021 •
edited
Loading

to be tested with liqd/adhocracy4@2d41aa7

@philli-m philli-m added the Dev: A4 depending PR or issue dependent on A4 label Dec 2, 2021
@philli-m philli-m force-pushed the pm-2021-12-map-refactor branch from 4044ca9 to e607551 Compare December 2, 2021 16:14
@khamui
Copy link
Contributor

khamui commented Dec 7, 2021 •
edited
Loading

working fine (without showing actual maps on my local, but that is expected).

these are the things i checked. To be verified on dev once merged

  • map in dashboard (where you select a Bezirk)
  • map and pins in project overview (combined map)
  • map and pins in list view (budgeting etc.)
  • map and pins in proposal view
  • map and creating pins in proposal view

is there more parts where i should check the maps?
and do we need to be aware of other projects because of the shifted files to a4?

approved and can be merged when is best!

@philli-m philli-m force-pushed the pm-2021-12-map-refactor branch from 40a376f to e9c30fc Compare December 9, 2021 10:49
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 4.7% 59/1254
🔴 Branches 3.46% 25/722
🔴 Functions 5.57% 23/413
🔴 Lines 8.56% 317/3702

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from e9c30fc

@philli-m philli-m merged commit c4c15a0 into main Dec 9, 2021
@philli-m philli-m deleted the pm-2021-12-map-refactor branch December 9, 2021 15:55
@philli-m philli-m mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzylogic2000 fuzzylogic2000 Awaiting requested review from fuzzylogic2000

@goapunk goapunk Awaiting requested review from goapunk

@khamui khamui Awaiting requested review from khamui

@Rineee Rineee Awaiting requested review from Rineee

Assignees
No one assigned
Labels
Dev: A4 depending PR or issue dependent on A4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philli-m @khamui