Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm 2021 12 03 inconsistent error messages issue #4030

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

sabinammm
Copy link
Contributor

@sabinammm sabinammm commented Dec 3, 2021

This fixes #4023.
In 1st Commit: error messages were consolidated in styling.
In 2nd Commit: new phrases are pulled in.
In 3rd Commit: translations are added to new error message text and new wording of existing error messages. This thus also fixes #4024.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 4.49% 56/1247
🔴 Branches 3.34% 24/718
🔴 Functions 5.6% 23/411
🔴 Lines 7.93% 291/3670

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 6ee9a1f

Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philli-m philli-m merged commit 96dca28 into main Dec 7, 2021
@philli-m philli-m deleted the sm-2021-12-03-inconsistent-error-messages-issue branch December 7, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants