Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

budgeting/templates/proposal-list: only show token form for 3 phase m… #4054

Merged

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Dec 13, 2021

…odules

fixes #4044

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. But this only occured for admins anyway, right? Still confusing, though. But if we do it in this slightly weird way, maybe instead of counting the phases, we can use the type and check if we have voting in the phases? But that is still weird, so we can also merge like this. Whatever you like more.

@github-actions
Copy link

github-actions bot commented Dec 13, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 4.77% 60/1258
🔴 Branches 3.59% 26/724
🔴 Functions 5.56% 23/414
🔴 Lines 8.65% 321/3711

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from a5a4bcc

@Rineee
Copy link
Contributor Author

Rineee commented Dec 13, 2021

Hmmm. But this only occured for admins anyway, right? Still confusing, though. But if we do it in this slightly weird way, maybe instead of counting the phases, we can use the type and check if we have voting in the phases? But that is still weird, so we can also merge like this. Whatever you like more.

@fuzzylogic2000 Well it only occurs for admins, because checking the permission always returns true for admins. For other users it checks the meinberlin_budgeting.vote_proposal, which is true if voting phase is active, so it doesnt show in 2 phase budgeting.

So I think we need to somehow know in the template if its a 2 or 3 phase? Or check if voting is in the phases, yes, thats also a possiblity, but I thought this was easier and kind of the same outcome? But if you prefer, I will also change it!

@Rineee Rineee force-pushed the ks-2021-12-only-show-token-form-for-3-phase-budgeting branch from 7209740 to a5a4bcc Compare December 13, 2021 09:25
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah!

@fuzzylogic2000 fuzzylogic2000 merged commit 092e412 into main Dec 13, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2021-12-only-show-token-form-for-3-phase-budgeting branch December 13, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontend idea list in pb with 1+2 phases: Code field is shown
2 participants