-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps/budgeting/api: more info in API and serializer #4063
Conversation
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 1909e3b |
@@ -28,6 +29,13 @@ def get_paginated_response(self, data): | |||
return response | |||
|
|||
|
|||
class LocaleInfoMixin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
if hasattr(proposal, 'moderator_feedback_choices'): | ||
return proposal.moderator_feedback_choices | ||
return (proposal.moderator_feedback, | ||
proposal.get_moderator_feedback_display()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better now :)
nice! |
@khamui I think that is all the info we need in the API now! :) And quite a lot of refactoring for the frontend, then...