Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/budgeting/api: more info in API and serializer #4063

Merged
merged 7 commits into from
Dec 16, 2021

Conversation

fuzzylogic2000
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 commented Dec 14, 2021

@khamui I think that is all the info we need in the API now! :) And quite a lot of refactoring for the frontend, then...

@github-actions
Copy link

github-actions bot commented Dec 14, 2021

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.6% 125/1302
🔴 Branches 7.58% 56/739
🔴 Functions 9.26% 40/432
🔴 Lines 16.35% 634/3878

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 1909e3b

@fuzzylogic2000 fuzzylogic2000 changed the title WIP: apps/budgeting/api: more info in API and serializer apps/budgeting/api: more info in API and serializer Dec 16, 2021
@@ -28,6 +29,13 @@ def get_paginated_response(self, data):
return response


class LocaleInfoMixin:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

if hasattr(proposal, 'moderator_feedback_choices'):
return proposal.moderator_feedback_choices
return (proposal.moderator_feedback,
proposal.get_moderator_feedback_display())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better now :)

@khamui
Copy link
Contributor

khamui commented Dec 16, 2021

nice!

@khamui khamui merged commit 980e305 into main Dec 16, 2021
@khamui khamui deleted the kl-2021-12-more-proposal-api-stuff branch December 16, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants