-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ks 2021 12 voting api #4067
Merged
Merged
Ks 2021 12 voting api #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rineee
force-pushed
the
ks-2021-12-voting-api
branch
from
December 16, 2021 09:29
426b049
to
f2d5ce3
Compare
Rineee
force-pushed
the
ks-2021-12-voting-api
branch
2 times, most recently
from
December 16, 2021 10:03
b43fd89
to
15cba52
Compare
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from d072700 |
Rineee
force-pushed
the
ks-2021-12-voting-api
branch
2 times, most recently
from
December 16, 2021 17:28
ec05a1f
to
baf193c
Compare
…ctions on voting button
…ing helpers.js to contrib and adjust all imports
Rineee
force-pushed
the
ks-2021-12-voting-api
branch
from
December 17, 2021 13:59
7fb19c8
to
b63f3ec
Compare
Rineee
force-pushed
the
ks-2021-12-voting-api
branch
from
December 17, 2021 14:03
b63f3ec
to
b57cce4
Compare
…y into 3 form fields
Rineee
force-pushed
the
ks-2021-12-voting-api
branch
from
December 17, 2021 14:36
b57cce4
to
d072700
Compare
fuzzylogic2000
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supercool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions are not yet there, so this is currently only really working for logged in users with a valid token (for not logged in users, the deletion is not allowed).
Also the count of votes left is not there yet as I wanted to wait if updating of the proposal list will work/how it will work and then I would it add it to response.data of proposals serializer. Do you think that is a good solution @fuzzylogic2000 ?
@Kha to test, you need a valid token. You can go to django admin and create one for your module. The annoying thing is that in the list of modules you can choose from only the internal name of the modules are displayed. To find the right one, you can check under modules what the name is.
As you know, the re-rendering doesnt work yet and also I am using this helper fuction from livequestions, that we could maybe use, but then move to contrib or write our own?
My todo is:
I dont know if we want to merge this already and go on from there or keep on working in branches? Up to you :)