Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/budgeting/proposal-item-detail/voting: making voting on detail view work #4079

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

khamui
Copy link
Contributor

@khamui khamui commented Dec 20, 2021

No description provided.

Kha added 2 commits December 20, 2021 14:11
template tag for detail proposal view.
distuingish between if VoteButton used as list-item(React) or as widget(Django) and fetch
differently
@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.74% 130/1335
🔴 Branches 7.83% 60/766
🔴 Functions 8.58% 38/443
🔴 Lines 17.22% 678/3937

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟡 meinberlin/apps/budgeting/assets/VoteButton.jsx 33.33% (-2.38% 🔻) 25% (-8.33% 🔻) 16.67% (-3.33% 🔻) 69.7% (-4.22% 🔻)
🔴 meinberlin/apps/budgeting/assets/react_vote_button_init.jsx 0% 0% (-100% 🔻) 0% 0%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 6a4c21b

Copy link
Contributor

@Rineee Rineee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, cool!

@Rineee Rineee merged commit b22af6d into main Dec 21, 2021
@Rineee Rineee deleted the kt-2021-12-voting-detail branch December 21, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants