Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/budgeting/filters: make initial fetch with defaults (querystring) #4102

Merged
merged 1 commit into from
Dec 21, 2021
Merged

apps/budgeting/filters: make initial fetch with defaults (querystring) #4102

merged 1 commit into from
Dec 21, 2021

Conversation

khamui
Copy link
Contributor

@khamui khamui commented Dec 21, 2021

closes #4101

@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.66% 129/1336
🔴 Branches 7.85% 60/764
🔴 Functions 8.56% 38/444
🔴 Lines 17.09% 674/3943

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🔴 meinberlin/apps/budgeting/assets/FilterBarDropdown.jsx 5% (-3.33% 🔻) 0% 0% 25.42%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 35c240f

fuzzylogic2000
fuzzylogic2000 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! 🙃

@fuzzylogic2000 fuzzylogic2000 merged commit 46501d9 into main Dec 21, 2021
@fuzzylogic2000 fuzzylogic2000 deleted the kt-2021-12-filter-default-fetch branch December 21, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzylogic2000 fuzzylogic2000 fuzzylogic2000 approved these changes

@philli-m philli-m Awaiting requested review from philli-m

@Rineee Rineee Awaiting requested review from Rineee

@sabinammm sabinammm Awaiting requested review from sabinammm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testing 5024: default for archived filter not working in react proposal list
2 participants
@khamui @fuzzylogic2000